Avoid loading large min and max terms in Lucene90BlockTreeTermsReader #132398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
fork_Lucene90BlockTreeTermsReader
branch
from
0aede54 to
a6f48f9
Compare
…ng large minTerm and maxTerm into jvm heap.
martijnvg
force-pushed
the
fork_Lucene90BlockTreeTermsReader
branch
from
a6f48f9 to
f1fc12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork Lucene90BlockTreeTermsReader and friends in order to avoid loading large minTerm and maxTerm into jvm heap.
The forked version would only be used by
ES812PostingsFormat, which is only used for tsdb and logsdb. This is because this code is already pegged toLucene90BlockTreeTermsReader. For other index modes, it depends on Lucene defaults (which isLucene101PostingsFormattoday) and if that gets changed then that can complicate a Lucene upgrade significantly.